Close definitely a DefaultSingleCDockable

system · April 13, 2011, 8:50am

Hello again!

I have checked a lot of threads in the forum and I have found this thread: http://forum.byte-welt.de/showthread.php?t=3325

I have the same problem as vjr… I have the same exception when I remove my DefaultSingleCDockable of the CController… I am using the version 1.0.8… So I have downloaded the last version…

I add my dockable using the add method of the CGrid in order to stack my dockable windows. And I use the remove method of the CController… OK, I no longer have the exception!

But if I want to add a second time the dockable with the same ID, 2 dockable windows are displayed with the same title tab… :mad:. When I remove the dockable, I wouldn’t like references in the CControl or something like that… Is it possible?

Fabien

Beni · April 13, 2011, 10:39am

It could be, that you only remove the Dockable from the CControl, but missed to make it invisible (call “setVisible(false)”). The Dockable would remain in the tree, just without any meta information.

If there are two tabs than there have to be two Dockables. But the framework should not allow you to register two Dockables with the same id, so this is a contradiction.

I would need to know exactly which methods you call in which order to give you a better answer.

system · April 15, 2011, 7:35am

Hi Beni,

First, I add my dockable using the following code:

this.add(0,0,1,1,createDockable(confSet, closeable));

where my class is an instance of CGrid and closeable equals to true

Then, to remove the dockable, I am using this code:

DefaultSingleCDockable dock = null;
        //Go throw my dockable
        for(int i=0; i<controller.getCDockableCount(); i++) {
            CDockable dockable = controller.getCDockable(i);
            //Search the dockable that I want to close
            if(((DefaultSingleCDockable)dockable).getUniqueId().equals(confSet.getID())) {
                //dockable found
                dock = (DefaultSingleCDockable)dockable;
                break;
            }
        }
        
        //Hide the dockable and remove it of the CController
        dock.setVisible(false);
        controller.remove(dock);

Then, the second time where I add the dockable, two tabs are opened. The first one can not be closeable but the second can be.

Beni · April 15, 2011, 8:08am

Are you using the same CGrid again to add the Dockable? If yes: the first Dockable is still in the grid, but it is no longer registered at the CControl because you removed it. But if you deploy the CGrid again, it gets visible again. Don’t use a CGrid for anything else then building the initial layout, it does never get cleared.

system · April 18, 2011, 1:23am

Yes I am using the same CGrid…
If I must not deploy the initial CGrid, I don’t understand which method I have to call to add a new dockable?

system · April 18, 2011, 2:00am

To precize my last post, I create my CController, I initialize my CGrid with 2 dockables and I deploy the my CGrid using the method getContentArea().deploy(grid) where grid is my CGrid instance. That’s the code for the setup of my application.

After, I need to add and remove dockables dynamically. If I had correctly understood your last post, I must not deploy a second time the CGrid. But, I don’t know how I can add new dockable to my initial CControlller… is it possible to give a little example?

Thanks!

Fabien

Beni · April 18, 2011, 3:19am

Like this:

DefaultSingleCDockable dockable = new MyDockable...

// find the CControl of your application
CControl control = ...

// register the dockable, allow control to collect and store meta data for "dockable"
control.addDockable( dockable );

// (optional) set the initial location, for example in the normalized area at the north end taking 25% space
dockable.setLocation( CLocation.base().normalNorth( 0.25 ) );

// make the dockable visible
dockable.setVisible( true );

system · April 21, 2011, 2:51am

Thanks!

system · April 22, 2011, 6:04am

I have a last question…

After using the addDockable in myCControl, how can I update the SingleCDockableListMenuPiece associated to my CControl in order to show the new menu associated to my Dockable? The SingleCDockableListMenuPiece was added to the initialization to my frame into a RootMenuPiece…

Fabien

system · April 22, 2011, 6:09am

I have forgot something in my last thread… For the moment, I call the method setControll on my SingleCDockableListMenuPiece. The menu item is updated!!!
But when I close my dockable using the red cross, if I want to display it again using the SingleCDockableListMenuPiece, nothing append… The dockable is not displayed…
Have you an idea?

Beni · April 22, 2011, 6:35am

Seems to be a bug of the framework, I’ll report back once I found and fixed it.

Beni · April 22, 2011, 6:40am

Or maybe not? The application below seems to work good. Is there anything different to your application?


import java.awt.event.ActionEvent;

import javax.swing.AbstractAction;
import javax.swing.JFrame;
import javax.swing.JMenu;
import javax.swing.JMenuBar;

import bibliothek.gui.dock.common.CControl;
import bibliothek.gui.dock.common.DefaultSingleCDockable;
import bibliothek.gui.dock.common.menu.SingleCDockableListMenuPiece;
import bibliothek.gui.dock.facile.menu.RootMenuPiece;

public class Dock01 {
	public static void main(String[] args) {
		JFrame frame = new JFrame();
		final CControl control = new CControl(frame);
		
		frame.add( control.getContentArea() );
		
		JMenuBar bar = new JMenuBar();
		JMenu base = new JMenu("File");
		base.add(new AbstractAction() {
			private int index = 0;
			
			{
				putValue(NAME, "Add");
			}
			
			@Override
			public void actionPerformed(ActionEvent arg0) {
				String id = "Dockable " + (index++);
				DefaultSingleCDockable dock = new DefaultSingleCDockable(id, id);
				dock.setCloseable(true);
				
				control.addDockable(dock);
				dock.setVisible(true);
			}
		});
		
		RootMenuPiece root = new RootMenuPiece("Dockables", true);
		SingleCDockableListMenuPiece menu = new SingleCDockableListMenuPiece(control);
		root.add(menu);

		bar.add(base);
		bar.add(root.getMenu());
		frame.setJMenuBar(bar);
		
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		frame.setBounds(20, 20, 400, 400);
		frame.setVisible(true);
	}
}

system · April 27, 2011, 6:04am

There is no difference with your code except the initialization of the SingleCDockableListMenuPiece. When the SingleCDockableListMenuPiece is invoked, my CControl is not instantiated. So I invoke the constructor with null as parameter and when I create a new dockable, I add it to the CControl and set the CControl to the SingleCDockableListMenuPiece using the setControl method of the SingleCDockableListMenuPiece class…

Beni · April 29, 2011, 2:20am

Sorry for not answering so long. Calling “setControl” later does not change the behavior of my application. Currently I don’t know what is going wrong.

Can you write me a small example that reproduces the bug, or somehow extract the code from your application? It looks as if some listeners are not installed correctly, are you perhaps using some unfortunate combination of submenus?