SplitDockStation resize bug in Eclipse theme

Hi Beni,

I noticed that when you use setContinousDisplay(true) with the Eclipse theme,
the horizontal resizing stops when you reach the width of the tab.

I could reproduce it in HelloWorldExample from Tutorial.
I added two lines:
31 controller.setTheme(new EclipseTheme());
53 station.setContinousDisplay(true);

Put Green on the left, resize horizontally.
The resizing stops at approximately the width of the tab (red or green).
If you put another dockable on Green and create a stack,
you can resize it all the way to the minimum size.

kind regards,
Maciej Modelski

Will be fixed in the next release. You wont be able to make the StackDockStation too small then. I just missed one implementation of “getPreferredSize”.

Thanks for the report.

Hi Beni,

I think that single(non stacked) dockables need to be fixed as well.
I don’t think that tab/title length is a good way of determining the minimum size.
It works fine in the basic theme - it stops at around 20 pixels, independently of the title.

kind regards,
Maciej Modelski

After testing the behavior a little bit with the repaired StackDockStation I have to agree. I think only using the minimum size of the Dockable itself would be a solution. So it would not be possible to shrink a layout such that a Dockable has negative width or height, but the title/tab could become quite small.

Hi Beni,

thanks for the fix, I tested p7a.
I found however two problems:

  1. In eclipse theme with closeable dockables, when the width of the dockable
    is smaller than the tab width, the close icon is painted over the title text.
    I think the title should be truncated.
  2. dockable.setTitleIcon( null ) has no effect. It still displays the default icon.
    This may have happened earlier, I didn’t check the last few previews.

For testing I used CommonHelloWorld from tutorial, with eclipse theme,
continuous display and closeable dockables.

kind regards,
Maciej Modelski

About 2: Call “CDockable.setTitleIconHandling” to tell the framework how a call to “setTitleIcon(null)” should be handled.

About 1: I think the old behavior is also fine, i.e. to simply cut off the tab if it doesn’t fit.

Hi Beni,

is the problem with the close icon painted over the title text on your todo list?
If not do you have some suggestions how I could fix it myself?

kind regards,
Maciej Modelski

Honestly: I did forget it… It is again on my todo list, will do it together with the focus issues you found.

I’ve uploaded a little update that should take care of the issue.

Hi Beni,

thanks for the fix!
However, I think the close icon should not be painted
if there is not enough space for it inside the tab.
Currently in the eclipse theme the close icon is painted even
if only the right end “Arch” part is visible.

kind regards,
Maciej Modelski

giamcanantoan.vn cungc?p Thuoc Giam Can (Thu?c Gi?mCân ), Thu?c Gi?m Béo uytín h? tr? Gi?m Cân Hi?u Qu? và Nhanh Chóng,Và Không T?ng Cân L?i
Xin g?i ??n các b?n nh?ng S?n Ph?m An Toàn Nh?t(Còn R?t Nhi?u Sp T?i Website Gi?m Cân An Toàn - Click ?? xem thêm:

Best SlimThu?c gi?m cânnhanh t? USA
Xu?t X?: M? /Quy Cách:40v-1pc / Giá: 1,200,000 ? - LH: 0986.960.960

**Gi?m Cân siêu c?p **BEAUTIFUL SLIM BODY
Xu?t X?: M? / Quy Cách: 36v/pcs / Giá: 890.000 ? - LH: 0986.960.960

** RELACORE Thu?c gi?m cân siêu c?p dành cho ng??i siêu m?p **
Xu?tX?: M? /Quy Cách:30v-1pc / Giá: 499.000 ? - LH: 0986.960.960

**Lishou - Gi?m Cân an toàn Ngu?n G?c Th?o D??c **
Xu?t X?: Hong Kong - / QuyCách: 40v-1pc / Giá:500,000? LH:0986.960.960
** **
Thu?c Gi?m Cân nhanh 2 DAY DIET(Mã 753)
Xu?t x?: Nh?t B?n / Quy Cách:60v/pcs / Giá: 439,000? - LH: 0986.960.960
** **
Thu?c Gi?m Cân cao c?p3X SLIMMING POWER
3X Slimming Power **
Xu?t x?: Nh?t B?n / Quy Cách:60v/pcs / Giá: 439,000? - LH: 0986.960.960
**Còn R?t Nhi?u S?n Ph?m Khác T?i GiamCanAnToan.vn – click ?? tìm hi?u các sp khác
Nhân d?p l?n ??u tiên tham gia di?n ?àn, GiamCanAnToan.vn[
??a ra ch??ng trình ?u ?ãi: ?Gi?m Cân An Toàn - „Nh? Nhàng“ ?ón Xuân? v?i m?c ?u ?ãi ??c bi?t khi các ch? em mua hàng và báo v?i ****GiamCanAnToan.vn "mình là member c?a di?n ?àn":
[ul][li]Gi?m 5% cho ??n hàng 1 s?n ph?m gi?m cân[
]gi?m 10% cho các ??n hàng t? 2 s?n ph?m tr? lên[
??c Bi?t T?t C? S? ???c T?ng 1 C?m Nang Gi?m Cân An Toàn do chính ??i ng? c?a GiamCanAnToan.vn t?ng h?p và biên so?n, nh?m tuy?t ??i hóa ??m b?o tuy?t ??i v?n ?? an toàn và hi?u qu? trong quá trình gi?m cân c?a các b?n
[/li]M?i th?c m?c lien quan xin vui long lien h? qua HotLine : 0986.960.960 - 0938.098.369 ?? ???c nh?n s? t? v?n và gi?i ?áp rõ ràng nh?t
C?a hang Thu?c Gi?m Cân An Toàn
??a Ch?: 105 Nguy?n Ki?m - F.3 - Gò V?p
Hotline: 0986.960.960 - 0938.098.369

Hm… The current behavior is very close to Eclipse itself, which does show the x until the last possible moment as well. But then I agree that the current solution is perhaps not the best one. I think I add some customization feature such that everyone can test and decide himself which solution he likes better.

Should be online before friday evening.

I agree, the close icon should be painted as long as it fits.
The problem is that currently it is painted even if it does not fit anymore - it goes outside of the tab.
It looks a bit ugly…

Alright, uploaded yet another fix. You can now decide for your own which behavior you preferre. To configure the tabs use code like in the example below. The usage of “TagConfiguration” should be self-explanatory, and the default settings are hopefully ok. If you are missing a setting, let me know.

CControl control = ...

control.putProperty( StackDockStation.TAB_CONFIGURATIONS, new TabConfigurations(){
	public TabConfiguration getConfiguration( Dockable dockable ){
		TabConfiguration config = new TabConfiguration();
		config.setActionHiding( ActionHiding.TEXT_DISAPPEARING );
		config.setIconHiding( IconHiding.NEVER );
		return config;
} );```

Thanks, that sounds good!
I wasn’t however able to test it - I think you forgot to include the classes
mentioned in the example…

Yes I did upload the wrong branch :o … sorry for wasting your time with stupid mistakes :mad:

The correct version is now uploaded, link

No problem, I had a sneak preview of some new features :wink:
Thanks again for the fix! I used the setting from the example.

M?t câu h?i quen thu?c v?i nh?ng khách hàng khi c?n ??n "tham tu tu” thuê thám t? ? ?âu Khi m?i quan h? gia ?ình, b? m?, v? ch?ng, con cái tr? nên ph?c t?p c?ng th?ng và c?n tìm ra m?t h??ng ?i ?úng, nh?ng l?i t? v?n, s? th?t c?n ???c sáng t?.

Gi?a hàng ch?c công ty thám t? t?i hà n?i, công ty thám t? Nam Vi?t n?i lên nh? m?t ??a ch? quen thu?c, s? l?a ch?n c?a khách hàng khi **c?n thuê ** "tham tu tu” t?i Hà N?i nói riêng c?ng nh? Vi?t Nam nói chung.

B?n c?n tìm hi?u thông tin v? ng??i thân xa nhà, mu?n làm rõ d?u hi?u quan h? ngoài lu?ng, ki?m tra nhân thân con r? ho?c ??i tác… B?n ?ang phân vân không bi?t thue tham tu o dau ? Hãy ?? Công ty thám t? t? Nam Vi?t, v?n phòng tham tu hàng ??u Vi?t Nam giúp b?n, r?t ??n gi?n b?n ch? c?n b?m máy g?i chúng tôi.

D?ch v? chúng tôi cung c?p:
[ul][li]Cung c?p thông tin v? ng??i thân s?ng xa nhà.[]Tìm hi?u v? các m?i quan h? xã h?i, t? v?n, qu?n lý giáo d?c con em.[]Qu?n lý, giám sát nh?ng ng??i ch?a ??n tu?i thành niên trong gia ?ình.[]Tìm ki?m và cung c?p thông tin v? vi?c nghi ng? ch?ng ho?c v? ngo?i tình.[]Tìm và cung c?p thông tin v? quan h? x?u có th? d?n t?i t? n?n xã h?i.[]Tìm ki?m ng??i già ?i l?c ???ng, con cái b? nhà ?i …[]Truy tìm và cung c?p thông tin v? các ??i t??ng l?a ??o, chi?m ?o?t, ?ánh c?p tài s?n …[*]Tìm và cung c?p thông tin khác theo yêu c?u trong quan h? dân s?, hôn nhân – gia ?ình.[/ul]Phòng 1803, Tòa nhà Láng H? Building, 101 Láng H?, Qu?n ??ng ?a, Hà N?i.
[/li]Tel: 04.66846836
Hotline: 098 357 2627 – 091 33 88 007